Parameters#183
Closed
carnegiemedal wants to merge 6 commits intoMarketSquare:masterfrom
Closed
Conversation
add parameters argument
pass parameters argument to execute function
added test using parameters argument
use correct list parameter
try different syntax for postgres, oracle etc.
extra syntax alternative for postgres, pymsql
Member
|
Thanks for the contribution! Parameters/args are officially supported in DBAPI2 and it makes sense to support them in DatabaseLibrary as well. We did some bigger changes recently and to make it easier to merge this PR I have reused your branch and created new PR (#198) - but all your commit history isretained. |
Collaborator
|
Implemented in #198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#146
Add an optional argument to a number of existing keywords for passing sql parameters.
These can then be inserted by the driver, avoiding the need to use variable substitution.
See also https://peps.python.org/pep-0249/#id20.